From notifications-return-6610-apmail-ignite-notifications-archive=ignite.apache.org@ignite.apache.org Sun Sep 8 10:47:55 2019 Return-Path: X-Original-To: apmail-ignite-notifications-archive@minotaur.apache.org Delivered-To: apmail-ignite-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id F365E19377 for ; Sun, 8 Sep 2019 10:47:54 +0000 (UTC) Received: (qmail 57177 invoked by uid 500); 8 Sep 2019 10:47:56 -0000 Delivered-To: apmail-ignite-notifications-archive@ignite.apache.org Received: (qmail 57164 invoked by uid 500); 8 Sep 2019 10:47:56 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 57155 invoked by uid 99); 8 Sep 2019 10:47:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Sep 2019 10:47:56 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] zaleslaw commented on a change in pull request #6853: IGNITE-12024: [ML] PeerClassloading for ml related lambdas Message-ID: <156793967423.10025.4016697233411497276.gitbox@gitbox.apache.org> Date: Sun, 08 Sep 2019 10:47:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zaleslaw commented on a change in pull request #6853: IGNITE-12024: [ML] PeerClassloading for ml related lambdas URL: https://github.com/apache/ignite/pull/6853#discussion_r322002874 ########## File path: modules/ml/src/main/java/org/apache/ignite/ml/clustering/kmeans/KMeansModel.java ########## @@ -125,4 +128,9 @@ public DistanceMeasure distanceMeasure() { .addField("centroids", centersList) .toString(); } + + /** {@inheritDoc} */ + @Override public List getDependencies() { Review comment: I suggest the page for Wiki in AI Wiki (you could start from the draft in the Google Doc and after review merge it into Wiki) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services