ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
Date Thu, 26 Sep 2019 09:12:39 GMT
zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore
option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
URL: https://github.com/apache/ignite/pull/6907#issuecomment-535415057
 
 
   About formatting, I use codestyle for two years the same like for other
   components, ok, I'll revert the formatting, but could you share please the
   link or file with codestyle (maybe somebody used outdated) and this is an
   issue.
   
   About test - I thought, it's not to easy to emulate because but I'll try
   
   ср, 25 сент. 2019 г. в 22:59, Nikolay <notifications@github.com>:
   
   > @zaleslaw <https://github.com/zaleslaw>
   >
   > Overall looks good.
   >
   >    1.
   >
   >    Seems your IDE code format changes differ from Ignite one. There is
   >    some nits in patch. Please, revert unnecessary changes.
   >    2.
   >
   >    Can we add the test for a new property?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/ignite/pull/6907?email_source=notifications&email_token=AAJEUHMODJ5L7MU3ARAPLT3QLO7KDA5CNFSM4I2MARJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7TE7HA#issuecomment-535187356>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAJEUHO7RXLXM5LLROUVOFLQLO7KDANCNFSM4I2MARJA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message