ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
Date Tue, 24 Sep 2019 12:04:05 GMT
pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r327574420
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/cache/query/SqlFieldsQuery.java
 ##########
 @@ -66,7 +69,7 @@
     private boolean collocated;
 
     /** Query timeout in millis. */
-    private int timeout;
+    private int timeout = DFLT_QUERY_TIMEOUT;
 
 Review comment:
   Also we will have some limitations regarding default timeout usage for other platform clients
and ODBC. For them it is impossible to realize if a default timeout should be used if current
values is 0. We can add handling of `-1` for them in this PR (similarly to `ClientCacheSqlFieldsQueryRequest`).
Changing platforms code can be done later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message