ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] Mmuzaf commented on a change in pull request #6825: IGNITE-12122 Remove setIncludeEventTypes from GridAbstractTest
Date Fri, 20 Sep 2019 09:09:51 GMT
Mmuzaf commented on a change in pull request #6825: IGNITE-12122 Remove setIncludeEventTypes
from GridAbstractTest
URL: https://github.com/apache/ignite/pull/6825#discussion_r326192705
 
 

 ##########
 File path: modules/camel/src/test/java/org/apache/ignite/stream/camel/IgniteCamelStreamerTest.java
 ##########
 @@ -96,6 +98,15 @@ public IgniteCamelStreamerTest() {
         super(true);
     }
 
+    /** {@inheritDoc} */
+    @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws
Exception {
+        IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
 
 Review comment:
   I'd suggest simplifying this block to (and for the similar cases below): 
   
   ```
           return super.getConfiguration(igniteInstanceName)
               .setIncludeEventTypes(EventType.EVTS_ALL);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message