ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6882: IGNITE-12044: Export histogram values as separate JMX attributes.
Date Thu, 19 Sep 2019 13:07:45 GMT
nizhikov commented on a change in pull request #6882: IGNITE-12044: Export histogram values
as separate JMX attributes.
URL: https://github.com/apache/ignite/pull/6882#discussion_r326163356
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/internal/metric/JmxMetricExporterSpiTest.java
 ##########
 @@ -131,17 +134,70 @@ public void testFilterAndExport() throws Exception {
 
         assertThrowsWithCause(new RunnableX() {
             @Override public void runx() throws Exception {
-                metricSet(ignite.name(), "filtered", "metric");
+                metricRegistry(ignite.name(), "filtered", "metric");
             }
         }, IgniteException.class);
 
-        DynamicMBean bean1 = metricSet(ignite.name(), "other", "prefix");
+        DynamicMBean bean1 = metricRegistry(ignite.name(), "other", "prefix");
 
         assertEquals(42L, bean1.getAttribute("test"));
         assertEquals(43L, bean1.getAttribute("test2"));
 
-        DynamicMBean bean2 = metricSet(ignite.name(), "other", "prefix2");
+        DynamicMBean bean2 = metricRegistry(ignite.name(), "other", "prefix2");
 
         assertEquals(44L, bean2.getAttribute("test3"));
     }
+
+    /** */
+    @Test
+    public void testHistogramSearchByName() throws Exception {
 
 Review comment:
   For now, we don't support interval changes.
   So, I don't think we should test it.
   
   Seems, we should re-register MBean if some metric change its properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message