ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] vveider commented on a change in pull request #4942: IGNITE-9836 Fixed check of java version with "ea" suffix
Date Mon, 16 Sep 2019 14:29:03 GMT
vveider commented on a change in pull request #4942: IGNITE-9836 Fixed check of java version
with "ea" suffix
URL: https://github.com/apache/ignite/pull/4942#discussion_r324706837
 
 

 ##########
 File path: bin/include/functions.sh
 ##########
 @@ -40,12 +40,7 @@ javaMajorVersion() {
     if [ ${version} -eq 1 ]; then
         # Version seems starts from 1, we need second number.
         javaVersion "$1"
-        backIFS=$IFS
-
-        IFS=. ver=(${version##*-})
-        version=${ver[1]}
-
-        IFS=$backIFS
+        version=$(echo ${version} | awk -F[\"\.] '{print $2}')
 
 Review comment:
   I would use the following notation:
   `version=$(awk -F[\"\.] '{print $2}' <<< ${version})`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message