ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
Date Fri, 13 Sep 2019 11:33:17 GMT
alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r324151337
 
 

 ##########
 File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlSystemViewsSelfTest.java
 ##########
 @@ -1293,7 +1302,7 @@ public void testCachesViews() throws Exception {
         assertEquals(0L, execSql("SELECT COUNT(*) FROM " + systemSchemaName() + ".CACHES
WHERE CACHE_NAME = 'no_such_cache'").get(0)
             .get(0));
 
-        assertEquals(0L, execSql("SELECT COUNT(*) FROM " + systemSchemaName() + ".CACHES
WHERE CACHE_NAME = 1").get(0).get(0));
+        //assertEquals(0L, execSql("SELECT COUNT(*) FROM " + systemSchemaName() + ".CACHES
WHERE CACHE_NAME = 1").get(0).get(0));
 
 Review comment:
   It's not an error, it was made on purpose to cover case that comparison with wrong data
type doesn't break the view, SQL should return an empty result set instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message