ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
Date Thu, 12 Sep 2019 13:18:19 GMT
alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r323734169
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheComparatorTest.java
 ##########
 @@ -42,10 +42,8 @@ public void testDirect() {
             null, true, null, true,
             false, null, new QuerySchema(), null);
 
-        assertEquals(-1,
-            ClusterCachesInfo.CacheComparators.DIRECT.compare(desc1, desc2));
+        assertTrue(ClusterCachesInfo.CacheComparators.DIRECT.compare(desc1, desc2) < 0);
 
 Review comment:
   After `compare` method was fixed this change is redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message