ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
Date Thu, 12 Sep 2019 10:52:09 GMT
alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r323676402
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java
 ##########
 @@ -185,6 +188,12 @@
      */
     public IgniteServiceProcessor(GridKernalContext ctx) {
         super(ctx);
+
+        ctx.metric().registerList(SVCS_MON_LIST, SVCS_MON_LIST_DESC,
+            ServiceView.class,
+            registeredServices,
+            s -> s,
+            s -> {});
 
 Review comment:
   If there are plans to use more such no-op cleaners in following-up PRs, perhaps it's better
to pass `null` and correctly handle nulls in `registerList` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message