ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] NSAmelchev commented on a change in pull request #6738: IGNITE-12027 NPE on try to read the MinimumNumberOfPartitionCopies metric.
Date Thu, 12 Sep 2019 10:49:15 GMT
NSAmelchev commented on a change in pull request #6738: IGNITE-12027 NPE on try to read the
MinimumNumberOfPartitionCopies metric.
URL: https://github.com/apache/ignite/pull/6738#discussion_r323675359
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupMetricsImpl.java
 ##########
 @@ -444,11 +472,25 @@ public void remove() {
      * @return Database.
      */
     private GridCacheDatabaseSharedManager database() {
+        if (!(ctx.shared().database() instanceof GridCacheDatabaseSharedManager))
+            return null;
+
         return (GridCacheDatabaseSharedManager)ctx.shared().database();
     }
 
     /** @return Metric group name. */
     private String metricGroupName() {
         return metricName(CACHE_GROUP_METRICS_PREFIX, ctx.cacheOrGroupName());
     }
+
+    /** @return {@code True} if topology started. */
+    private boolean isTopologyStarted() {
 
 Review comment:
   Done. TC bot is OK. @nizhikov Take a look, please.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message