ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
Date Wed, 11 Sep 2019 14:14:32 GMT
alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r323265835
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/list/AbstractMonitoringList.java
 ##########
 @@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.metric.list;
+
+import org.apache.ignite.spi.metric.list.MonitoringList;
+import org.apache.ignite.spi.metric.list.MonitoringRow;
+import org.apache.ignite.spi.metric.list.MonitoringRowAttributeWalker;
+
+/**
+ *
+ */
+abstract class AbstractMonitoringList<R extends MonitoringRow> implements MonitoringList<R>
{
+    /** Name of the list. */
+    private final String name;
+
+    /** Description of the list. */
+    private final String description;
+
+    /** Class of the row */
+    private final Class<R> rowClass;
+
+    /**
+     * Row attribute walker.
+     *
+     * @see org.apache.ignite.codegen.MonitoringRowAttributeWalkerGenerator
+     */
+    private final MonitoringRowAttributeWalker<R> walker;
+
+    /**
+     * @param name Name of the list.
+     * @param description Description of the list.
+     * @param rowClass Class of the row.
+     * @param walker Row attribute walker.
+     */
+    AbstractMonitoringList(String name, String description, Class<R> rowClass, MonitoringRowAttributeWalker<R>
walker) {
 
 Review comment:
   It's desirable to use abbreviations for "description" and "class"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message