ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework.
Date Wed, 11 Sep 2019 13:55:09 GMT
nizhikov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics
ported to a new framework.
URL: https://github.com/apache/ignite/pull/6814#discussion_r323255058
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/util/nio/GridNioServer.java
 ##########
 @@ -2860,14 +2895,17 @@ final void reset0() {
      * Gets outbound messages queue size.
      *
      * @return Write queue size.
+     * @deprecated Will be removed in the next major release and replaced with new metrics
API.
      */
+    @Deprecated
     public int outboundMessagesQueueSize() {
-        int res = 0;
-
-        for (GridSelectorNioSessionImpl ses : sessions)
-            res += ses.writeQueueSize();
+        if (mreg == null)
+            return -1;
 
-        return res;
+        return (int) mreg.longAdderMetric(
 
 Review comment:
   We should store `LongMetric` inside object instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message