ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6737: IGNITE-11944 [IEP-35] OpencensusExporter should export Histogram metrics
Date Wed, 11 Sep 2019 12:33:27 GMT
nizhikov commented on a change in pull request #6737: IGNITE-11944  [IEP-35] OpencensusExporter
should export Histogram metrics
URL: https://github.com/apache/ignite/pull/6737#discussion_r323213840
 
 

 ##########
 File path: modules/opencensus/src/main/java/org/apache/ignite/spi/metric/opencensus/OpenCensusMetricExporterSpi.java
 ##########
 @@ -183,6 +205,36 @@ else if (metric instanceof DoubleMetric) {
 
                         mmap.put(msr, val);
                     }
+                    else if (metric instanceof HistogramMetric) {
+                        /*
+                            Histogram exports as a separate long metric for each interval.
+                            Example of metric names if bounds are 10,100:
+                                histogram_0_10 (less than 10)
+                                histogram_10_100 (between 10 and 100)
+                                histogram_100_inf (more than 100)
+                         */
+                        long[] value = ((HistogramMetric)metric).value();
 
 Review comment:
   A variable should be named `values`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message