ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6737: IGNITE-11944 [IEP-35] OpencensusExporter should export Histogram metrics
Date Wed, 11 Sep 2019 12:30:57 GMT
nizhikov commented on a change in pull request #6737: IGNITE-11944  [IEP-35] OpencensusExporter
should export Histogram metrics
URL: https://github.com/apache/ignite/pull/6737#discussion_r323213084
 
 

 ##########
 File path: modules/opencensus/src/main/java/org/apache/ignite/spi/metric/opencensus/OpenCensusMetricExporterSpi.java
 ##########
 @@ -118,6 +120,26 @@
      */
     private Map<String, Measure> measures = new HashMap<>();
 
+    /** Cached histogram metrics intervals names. */
+    private Map<T2<String, long[]>, String[]> histogramNames = new HashMap<>();
 
 Review comment:
   Seems, a map is not cleared on `MetricRegistry` remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message