ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] daradurvs commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
Date Mon, 09 Sep 2019 20:44:27 GMT
daradurvs commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r322414228
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java
 ##########
 @@ -106,9 +118,25 @@
     /** Dynamic caches. */
     private final ConcurrentMap<String, DynamicCacheDescriptor> registeredCaches =
new ConcurrentHashMap<>();
 
+    /**
+     * Monitoring list for caches.
+     *
+     * @see ReadOnlyMonitoringListRegistry
+     * @see GridMetricManager
+     */
+    @Nullable private volatile MonitoringListImpl<String, CacheView> cachesMonList;
+
     /** */
     private final ConcurrentMap<Integer, CacheGroupDescriptor> registeredCacheGrps
= new ConcurrentHashMap<>();
 
+    /**
+     * Monitoring list for cache groups.
+     *
+     * @see ReadOnlyMonitoringListRegistry
+     * @see GridMetricManager
+     */
+    @Nullable private volatile MonitoringListImpl<Integer, CacheGroupView> cachesGrpMonList;
 
 Review comment:
   volatile is not required - as far as I can see, the field will be processed only by discovery
thread

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message