ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] AMashenkov commented on a change in pull request #6839: IGNITE-11815: replace GridTestUtils.retryAssert with GridTestUtils.waitForCondition
Date Thu, 05 Sep 2019 11:37:51 GMT
AMashenkov commented on a change in pull request #6839: IGNITE-11815: replace GridTestUtils.retryAssert
with GridTestUtils.waitForCondition
URL: https://github.com/apache/ignite/pull/6839#discussion_r321211052
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/internal/managers/checkpoint/GridCheckpointManagerAbstractSelfTest.java
 ##########
 @@ -751,13 +711,13 @@ private boolean checkCheckpointManager(Ignite g) throws Exception {
     }
 
     /**
-     * Wrapper around {@link GridTestUtils#retryAssert(org.apache.ignite.IgniteLogger, int,
long, GridAbsClosure)}.
+     * Wrapper around {@link GridTestUtils#waitForCondition(org.apache.ignite.internal.util.lang.GridAbsPredicate,
long).
      * For the given closure provides count of retries, configured by {@link #retries} attribute.
      * @param assertion Closure with assertion inside.
 
 Review comment:
   Method semantic has been changed.
   Now "assertion" param is a closure with condition and no assertion is expected to be thrown
from the closure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message