ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] antonovsergey93 commented on a change in pull request #6833: IGNITE-12135 Rework GridCommandHandlerTes.:
Date Thu, 05 Sep 2019 10:38:43 GMT
antonovsergey93 commented on a change in pull request #6833: IGNITE-12135 Rework GridCommandHandlerTes.:
URL: https://github.com/apache/ignite/pull/6833#discussion_r321186132
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/visor/verify/VisorIdleVerifyTaskArg.java
 ##########
 @@ -191,13 +194,15 @@ protected void skipZeros(boolean skipZeros) {
 
     /** */
     protected void cacheFilterEnum(CacheFilterEnum cacheFilterEnum) {
-        this.cacheFilterEnum = (cacheFilterEnum == null ? CacheFilterEnum.DEFAULT : cacheFilterEnum);
+        assert nonNull(cacheFilterEnum);
+
+        this.cacheFilterEnum = cacheFilterEnum;
     }
 
     /**
      * @return Kind fo cache.
      */
-    public CacheFilterEnum cacheFilterEnum() {
+    @NotNull public CacheFilterEnum cacheFilterEnum() {
 
 Review comment:
   We don't use `@NotNull` annotations https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-@Annotations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message