From notifications-return-6466-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Aug 23 09:04:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9E63E180637 for ; Fri, 23 Aug 2019 11:04:38 +0200 (CEST) Received: (qmail 32855 invoked by uid 500); 23 Aug 2019 09:04:36 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 32812 invoked by uid 99); 23 Aug 2019 09:04:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Aug 2019 09:04:36 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ygerzhedovich commented on a change in pull request #6456: IGNITE-11470: Views don't show in Dbeaver Message-ID: <156655107652.31948.10834326496281861357.gitbox@gitbox.apache.org> Date: Fri, 23 Aug 2019 09:04:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ygerzhedovich commented on a change in pull request #6456: IGNITE-11470: Views don't show in Dbeaver URL: https://github.com/apache/ignite/pull/6456#discussion_r317039862 ########## File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java ########## @@ -1758,6 +1770,114 @@ public UpdateResult executeUpdateOnDataNode( return schemaMgr.schemaNames(); } + /** {@inheritDoc} */ + @Override public Collection tablesInformation(String schemaNamePtrn, String tblNamePtrn, + String... tblTypes) { + Set types = F.isEmpty(tblTypes) ? Collections.emptySet() : new HashSet<>(Arrays.asList(tblTypes)); + + Collection infos = new ArrayList<>(); + + boolean allTypes = F.isEmpty(tblTypes); + + if (allTypes || types.contains(TableType.TABLE.name())) { + schemaMgr.dataTables().stream() + .filter(t -> matches(t.getSchema().getName(), schemaNamePtrn)) + .filter(t -> matches(t.getName(), tblNamePtrn)) + .map(t -> { + int cacheGrpId = t.cacheInfo().groupId(); + + CacheGroupDescriptor cacheGrpDesc = ctx.cache().cacheGroupDescriptors().get(cacheGrpId); + + // We should skip table in case in case regarding cache group has been removed. Review comment: fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services