From notifications-return-6060-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Aug 16 15:49:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EAB5618057A for ; Fri, 16 Aug 2019 17:49:55 +0200 (CEST) Received: (qmail 26864 invoked by uid 500); 16 Aug 2019 15:49:55 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 26855 invoked by uid 99); 16 Aug 2019 15:49:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2019 15:49:55 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change. Message-ID: <156597059529.6696.5193072417721373428.gitbox@gitbox.apache.org> Date: Fri, 16 Aug 2019 15:49:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change. URL: https://github.com/apache/ignite/pull/6770#discussion_r314781290 ########## File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java ########## @@ -414,6 +416,11 @@ protected static void assertSqlSimpleData(Ignite node, String sql, int expSize) ", ids=" + ids + ']', expSize, res.size()); } catch (Exception e) { + for (Throwable th = e; th != null; th = th.getCause()) { + if (th.getMessage().contains(CONC_DESTROY_MSG)) + return; Review comment: Also it would be great to have a test checking that exception with CONC_DESTROY_MSG is a proper SQL exception (with useful meaning for e.g. JDBC). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services