From notifications-return-6034-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Aug 16 08:38:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60A44180651 for ; Fri, 16 Aug 2019 10:38:56 +0200 (CEST) Received: (qmail 28248 invoked by uid 500); 16 Aug 2019 08:38:53 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 28193 invoked by uid 99); 16 Aug 2019 08:38:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2019 08:38:53 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change. Message-ID: <156594473348.26226.1564549862284167914.gitbox@gitbox.apache.org> Date: Fri, 16 Aug 2019 08:38:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change. URL: https://github.com/apache/ignite/pull/6770#discussion_r314606036 ########## File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2Tree.java ########## @@ -59,6 +59,9 @@ * H2 tree index implementation. */ public class H2Tree extends BPlusTree { + /** */ + public static final String IGNITE_THROTTLE_INLINE_SIZE_CALCULATION = "IGNITE_THROTTLE_INLINE_SIZE_CALCULATION"; Review comment: Why do not we place property name constant to `IgniteSystemProperties` class as usual? With a bit of description in javadoc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services