From notifications-return-5926-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sun Aug 11 05:54:59 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 711201806C7 for ; Sun, 11 Aug 2019 07:54:57 +0200 (CEST) Received: (qmail 70871 invoked by uid 500); 11 Aug 2019 05:54:56 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 70749 invoked by uid 99); 11 Aug 2019 05:54:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Aug 2019 05:54:56 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] pavlukhin commented on a change in pull request #6760: IGNITE-12051: update javadoc for IgniteKernal class Message-ID: <156550289629.10974.4782583023163456688.gitbox@gitbox.apache.org> Date: Sun, 11 Aug 2019 05:54:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pavlukhin commented on a change in pull request #6760: IGNITE-12051: update javadoc for IgniteKernal class URL: https://github.com/apache/ignite/pull/6760#discussion_r312723044 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java ########## @@ -293,52 +294,79 @@ import static org.apache.ignite.lifecycle.LifecycleEventType.BEFORE_NODE_START; /** - * Ignite kernal. - *

- * See http://en.wikipedia.org/wiki/Kernal for information on the - * misspelling. + * This class represents an implementation of the extended main Ignite API (called {@link IgniteEx}). It also controls + * the Ignite life cycle and allows listening for Ignite events. + *

+ * Please, refer to the wiki http://en.wikipedia.org/wiki/Kernal + * for the information on the misspelling. + *

+ *

Start point

+ * The main entry point for all the Ignite instances creation is the org.apache.ignite.internal.IgniteKernal#start() + * method. It starts internal Ignites components (see {@link GridComponent}), for instance: + *
    + *
  • {@link GridManager} - a layer of indirection between kernal and SPI modules.
  • + *
  • {@link GridProcessor} - an objects responsible for particular internal process implementation.
  • + *
  • {@link IgnitePlugin} - an Ignite addition of user-provided functionality.
  • + *
+ * The start() method also perfoms additional validation of the provided {@link IgniteConfiguration} and Review comment: Why not `@link` or `@code`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services