ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6734: IGNITE-9410 Thin client transactions support
Date Tue, 27 Aug 2019 06:58:44 GMT
alex-plekhanov commented on a change in pull request #6734: IGNITE-9410 Thin client transactions
support
URL: https://github.com/apache/ignite/pull/6734#discussion_r317920704
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientConnectionContext.java
 ##########
 @@ -85,6 +99,15 @@
     /** Cursor counter. */
     private final AtomicLong curCnt = new AtomicLong();
 
+    /** Tx id. */
+    private final AtomicInteger txIdSeq = new AtomicInteger();
 
 Review comment:
   I think `int` is more than enough here. Transaction ids can be reused and It's practically
impossible that one transaction is still active and after 4*10^9 transactions started by the
same connection new one with the same id started.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message