ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6734: IGNITE-9410 Thin client transactions support
Date Thu, 22 Aug 2019 10:52:47 GMT
alex-plekhanov commented on a change in pull request #6734: IGNITE-9410 Thin client transactions
support
URL: https://github.com/apache/ignite/pull/6734#discussion_r316612689
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientTransactions.java
 ##########
 @@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.client.thin;
+
+import org.apache.ignite.client.ClientException;
+import org.apache.ignite.client.ClientTransaction;
+import org.apache.ignite.client.ClientTransactions;
+import org.apache.ignite.configuration.ClientTransactionConfiguration;
+import org.apache.ignite.internal.binary.BinaryRawWriterEx;
+import org.apache.ignite.internal.binary.BinaryWriterExImpl;
+import org.apache.ignite.transactions.TransactionConcurrency;
+import org.apache.ignite.transactions.TransactionIsolation;
+
+import static org.apache.ignite.internal.client.thin.ProtocolVersion.V1_5_0;
+
+/**
+ * Implementation of {@link ClientTransactions} over TCP protocol.
+ */
+class TcpClientTransactions implements ClientTransactions {
+    /** Transaction label. */
+    private String lb;
+
+    /** Channel. */
+    private final ReliableChannel ch;
+
+    /** Marshaller. */
+    private final ClientBinaryMarshaller marsh;
+
+    /** Current thread transaction. */
+    private final ThreadLocal<TcpClientTransaction> tx = new ThreadLocal<>();
 
 Review comment:
   We can't make `TcpClientTransaction` static, because we need `TcpClientTransactions` context
here. 
   I don't quite understand how we can get possible leak here. If nobody holds the reference
to `TcpClientTransactions` instance and nobody holds the reference to `TcpClientTransaction`
instances, which were created by this `TcpClientTransactions`, the only references left outside
of garbage objects it's a `WeakReference` to `ThreadLocal` from threads which have used this
`TcpClientTransactions` instance. These weak references don't prevent to collect garbage objects.

   Did I miss something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message