ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
Date Tue, 20 Aug 2019 08:38:52 GMT
pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
URL: https://github.com/apache/ignite/pull/6770#discussion_r315570349
 
 

 ##########
 File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/SchemaManager.java
 ##########
 @@ -616,6 +616,10 @@ public void dropIndex(final String schemaName, String idxName, boolean
ifExists)
         throws IgniteCheckedException{
         String sql = H2Utils.indexDropSql(schemaName, idxName, ifExists);
 
+        GridH2Table tbl = dataTableForIndex(schemaName, idxName);
 
 Review comment:
   I was concerned more about access to tables using `schema(schemaName).tables`. Used a _stream_
syntax just for a one-liner in a comment. _For_ vs _stream_ does not look as a big deal for
me here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message