ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
Date Sun, 18 Aug 2019 03:52:08 GMT
pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
URL: https://github.com/apache/ignite/pull/6770#discussion_r314967246
 
 

 ##########
 File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/SchemaManager.java
 ##########
 @@ -616,6 +616,12 @@ public void dropIndex(final String schemaName, String idxName, boolean
ifExists)
         throws IgniteCheckedException{
         String sql = H2Utils.indexDropSql(schemaName, idxName, ifExists);
 
+        GridH2Table tbl = dataTableForIndex(schemaName, idxName);
+
+        assert tbl != null;
+
+        tbl.setRemoveIndexOnDestroy(true);
 
 Review comment:
   I am thinking about a race condition when an index is being dropped and a cache is stopping
on deactivation concurrently. A following invalid scenario looks possible:
   1. On deactivation `rmIndex` flag is set to false.
   2. On index drop `rmIndex`is set to true. Index is dropped.
   3. `rmIndex == true` leads that all indexes are destroyed on deactivation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message