ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
Date Sun, 18 Aug 2019 03:43:19 GMT
pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline size change.
URL: https://github.com/apache/ignite/pull/6770#discussion_r314967092
 
 

 ##########
 File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java
 ##########
 @@ -414,6 +416,11 @@ protected static void assertSqlSimpleData(Ignite node, String sql, int
expSize)
                 ", ids=" + ids + ']', expSize, res.size());
         }
         catch (Exception e) {
+            for (Throwable th = e; th != null; th = th.getCause()) {
+                if (th.getMessage().contains(CONC_DESTROY_MSG))
+                    return;
 
 Review comment:
   I am not about checking all tests manually. I am about a change that makes `assertSqlSimpleData`
to pass for a case when it failed beforehand.  Here it is an exception with `CONC_DESTROY_MSG`.
Now all tests using this method will pass if a tested query simply throw an exception with
`CONC_DESTROY_MSG`. And I suppose it is not an expected behaviour for tests using this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message