ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] ptupitsyn commented on a change in pull request #6734: IGNITE-9410 Thin client transactions support
Date Thu, 15 Aug 2019 08:42:14 GMT
ptupitsyn commented on a change in pull request #6734: IGNITE-9410 Thin client transactions
support
URL: https://github.com/apache/ignite/pull/6734#discussion_r314220898
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/tx/ClientTxEndRequest.java
 ##########
 @@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.platform.client.tx;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.binary.BinaryRawReader;
+import org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxLocal;
+import org.apache.ignite.internal.processors.platform.client.ClientConnectionContext;
+import org.apache.ignite.internal.processors.platform.client.ClientRequest;
+import org.apache.ignite.internal.processors.platform.client.ClientResponse;
+import org.apache.ignite.internal.processors.platform.client.ClientStatus;
+import org.apache.ignite.internal.processors.platform.client.IgniteClientException;
+
+/**
+ * End the transaction request.
+ */
+public class ClientTxEndRequest extends ClientRequest implements ClientTxAwareRequest {
+    /** Transaction id. */
+    private final int txId;
+
+    /** Transaction committed. */
+    private final boolean committed;
+
+    /**
+     * Constructor.
+     *
+     * @param reader Reader.
+     */
+    public ClientTxEndRequest(BinaryRawReader reader) {
+        super(reader);
+
+        txId = reader.readInt();
+        committed = reader.readBoolean();
+    }
+
+    /** {@inheritDoc} */
+    @Override public ClientResponse process(ClientConnectionContext ctx) {
+        ClientTxContext txCtx = ctx.txContext(txId);
+
+        if (txCtx == null && !committed)
+            return super.process(ctx);
+
+        if (txCtx == null)
+            throw new IgniteClientException(ClientStatus.TX_NOT_FOUND, "Transaction with
id " + txId + " not found.");
+
+        try (GridNearTxLocal tx = txCtx.tx()) {
+            if (committed)
+                tx.commit();
+            else
+                tx.rollback();
+        }
+        catch (IgniteCheckedException e) {
+            throw new IgniteClientException(ClientStatus.FAILED, e.getMessage(), e);
 
 Review comment:
   Do we need this catch block at all? I think exceptions are handled up the stack anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message