ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6760: IGNITE-12051: update javadoc for IgniteKernal class
Date Sun, 11 Aug 2019 05:54:56 GMT
pavlukhin commented on a change in pull request #6760: IGNITE-12051: update javadoc for IgniteKernal
class
URL: https://github.com/apache/ignite/pull/6760#discussion_r312723492
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
 ##########
 @@ -347,35 +375,44 @@
     /** Spring context, potentially {@code null}. */
     private GridSpringResourceContext rsrcCtx;
 
-    /** */
+    /**
+     * The instance of scheduled thread pool starvation checker. {@code null} if starvation
checks have been
+     * disabled by the value {@link IgniteSystemProperties#IGNITE_STARVATION_CHECK_INTERVAL}
system property.
+     */
     @GridToStringExclude
     private GridTimeoutProcessor.CancelableTask starveTask;
 
-    /** */
+    /**
+     * The instance of scheduled metrics logger. {@code null} means that the metrics logges
have been disabled
+     * by configuration. See {@link IgniteConfiguration#getMetricsLogFrequency()} for details.
+     */
     @GridToStringExclude
     private GridTimeoutProcessor.CancelableTask metricsLogTask;
 
-    /** */
+    /**
+     * The instance of scheduled long operation checker. {@code null} means that the operations
checker is disabled
+     * by the value of {@link IgniteSystemProperties#IGNITE_LONG_OPERATIONS_DUMP_TIMEOUT}
system property.
+     */
     @GridToStringExclude
     private GridTimeoutProcessor.CancelableTask longOpDumpTask;
 
-    /** Indicate error on grid stop. */
+    /** {@code true} if an error occur at Ignite instance stop. */
     @GridToStringExclude
     private boolean errOnStop;
 
-    /** Scheduler. */
+    /** An instance of the scheduler which provides functionality for scheduling jobs locally.
*/
     @GridToStringExclude
     private IgniteScheduler scheduler;
 
-    /** Kernal gateway. */
+    /** The kernal state guard. See {@link GridKernalGateway} for details. */
     @GridToStringExclude
     private final AtomicReference<GridKernalGateway> gw = new AtomicReference<>();
 
-    /** Stop guard. */
+    /** Flag indicates that the ignite instance is scheduled to be stopped. */
     @GridToStringExclude
     private final AtomicBoolean stopGuard = new AtomicBoolean();
 
-    /** */
+    /** The state object is used to handle if reconnection occurred. See {@link IgniteKernal#onReconnected(boolean)}.
*/
 
 Review comment:
   Suggestions to rearrange:
   * The state object is used _to handle reconnection_.
   * The state object is used _when reconnection occurs_.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message