ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #5619: IGNITE-10619: CommunicationSpi support channels initial commit
Date Wed, 07 Aug 2019 16:01:45 GMT
alex-plekhanov commented on a change in pull request #5619: IGNITE-10619: CommunicationSpi
support channels initial commit
URL: https://github.com/apache/ignite/pull/5619#discussion_r311623108
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
 ##########
 @@ -1893,7 +1968,7 @@ public TcpCommunicationSpi setSlowClientQueueLimit(int slowClientQueueLimit)
{
 
     /** {@inheritDoc} */
     @Override public void setListener(CommunicationListener<Message> lsnr) {
-        this.lsnr = lsnr;
+        this.lsnr = (CommunicationListenerEx<Message>)lsnr;
 
 Review comment:
   Why don't we explicitly check here class of lsnr? It's a public method for public API,
this fix potentially can break something. I think it's better to leave lsnr class and this
method as is and do additional check in `notifyChannelEvtListener` method. Perhaps you don't
need to change test listeners in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message