ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
Date Mon, 05 Aug 2019 14:28:56 GMT
agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
URL: https://github.com/apache/ignite/pull/6696#discussion_r310598464
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/mxbean/IgniteMXBean.java
 ##########
 @@ -505,4 +505,16 @@ void runIoTest(
     @MXBeanParametersNames("registry")
     @MXBeanParametersDescriptions("Metrics registry.")
     public void resetMetrics(String registry);
+
+    /**
+     * Change metric configuration.
+     *
+     * @param registry Metrics registry name.
+     * @param name Metric name.
+     * @param config Configuration string.
+     */
+    @MXBeanDescription("Configure metric by name.")
+    @MXBeanParametersNames({"registry", "name", "config"})
+    @MXBeanParametersDescriptions({"Registry name.", "Metric name.", "Configuration string."})
+    public void configureMetric(String registry, String name, String config);
 
 Review comment:
   May be we should return some meaningful value (instead of `void`) that will answer to question
was metric succesfuly reconfigured or not?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message