ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
Date Mon, 05 Aug 2019 14:28:56 GMT
agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
URL: https://github.com/apache/ignite/pull/6696#discussion_r310597065
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/HistogramMetric.java
 ##########
 @@ -96,6 +100,37 @@ public void reset(long[] bounds) {
         return long[].class;
     }
 
+    /** {@inheritDoc} */
+    @Override public void configure(String cfg) throws IgniteException {
+        if (cfg == null || "".equals(cfg))
+            throw new IgniteException(name() + ". Config is empty. " + EXP_FMT_MSG);
+
+        String[] boundsStr = cfg.split(",");
+
+        long[] bounds = new long[boundsStr.length];
+
+        for (int i = 0; i < boundsStr.length; i++) {
+            try {
+                long b = Long.valueOf(boundsStr[i].trim());
+
+                if (b <= 0)
 
 Review comment:
   Any text debug/logging output should follow rules described here: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-StringOutput

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message