ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
Date Mon, 05 Aug 2019 14:28:56 GMT
agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
URL: https://github.com/apache/ignite/pull/6696#discussion_r310589683
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/metric/Metric.java
 ##########
 @@ -36,4 +37,13 @@
     public default void reset() {
         // No-op.
     }
+
+    /**
+     * Change metric configuration.
+     *
+     * @throws IgniteException If configuration failed.
+     */
+    public default void configure(String cfg) throws IgniteException {
 
 Review comment:
   `configure` method on this interface is over kill. Most metrics never change their configuration.

   
   Moreover `Metric`'s responsibility are just value accounting and providing, not configuration.
Actually reconfiguration is just creation of new metric. 
   
   From my point of view this method should be removed and configuration must be performed
in place in `IgniteKernal.configureMetric`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message