From notifications-return-4701-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Jul 30 12:07:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6952F180607 for ; Tue, 30 Jul 2019 14:07:53 +0200 (CEST) Received: (qmail 33025 invoked by uid 500); 30 Jul 2019 12:07:52 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 33016 invoked by uid 99); 30 Jul 2019 12:07:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jul 2019 12:07:52 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] NSAmelchev commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings Message-ID: <156448847271.18709.105167029925342491.gitbox@gitbox.apache.org> Date: Tue, 30 Jul 2019 12:07:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit NSAmelchev commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings URL: https://github.com/apache/ignite/pull/6701#discussion_r308683152 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java ########## @@ -2705,6 +2731,31 @@ else if (fut.isDone() && fut.topologyVersion().compareTo(from) >= 0) return true; } + /** + * @param blocked {@code True} If take into account only cache operations blocked PME. + * @return Gets execution duration for current partition map exchange in milliseconds. {@code 0} If there is no + * running PME or {@code blocked} was set to {@code true} and current PME don't block cache operations. + */ + private long getCurrentPMEDuration(boolean blocked) { + GridDhtPartitionsExchangeFuture fut = lastTopologyFuture(); + + return fut == null ? 0 : fut.getCurrentPMEDuration(blocked); + } + + /** + * @return Histogram of PME durations metric. + */ + public HistogramMetric getDurationHistogram() { + return durationHistogram; + } + + /** + * @return Histogram of blocking PME durations metric. + */ + public HistogramMetric getBlockingDurationHistogram() { Review comment: Thanks. Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services