From notifications-return-4656-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Jul 29 11:41:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EAE7F18063F for ; Mon, 29 Jul 2019 13:41:55 +0200 (CEST) Received: (qmail 13739 invoked by uid 500); 29 Jul 2019 11:41:55 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 13729 invoked by uid 99); 29 Jul 2019 11:41:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jul 2019 11:41:55 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] NSAmelchev commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings Message-ID: <156440050995.20057.2399314369422313939.gitbox@gitbox.apache.org> Date: Mon, 29 Jul 2019 11:41:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit NSAmelchev commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings URL: https://github.com/apache/ignite/pull/6701#discussion_r308184963 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java ########## @@ -476,6 +489,19 @@ else if (m instanceof GridDhtPartitionDemandLegacyMessage) { }); } } + + MetricRegistry mreg = cctx.kernalContext().metric().registry(PME_METRICS); + + mreg.register(CURRENT_PME_DURATION, + () -> getCurrentPMEDuration(false), + "Current PME duration in milliseconds."); + + mreg.register(CURRENT_PME_CACHE_OPERATIONS_BLOCKED_DURATION, Review comment: @nizhikov What do you think about `CURRENT_PME_OPS_BLOCKED_DURATION`? To avoid confusion with histograms. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services