From notifications-return-4630-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jul 26 09:06:37 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CF3A6180595 for ; Fri, 26 Jul 2019 11:06:36 +0200 (CEST) Received: (qmail 25624 invoked by uid 500); 26 Jul 2019 09:06:36 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 25615 invoked by uid 99); 26 Jul 2019 09:06:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2019 09:06:36 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] anton-vinogradov commented on issue #6701: IGNITE-11961 Provide JMX metrics for PME timings Message-ID: <156413199616.18882.14332458835816420021.gitbox@gitbox.apache.org> Date: Fri, 26 Jul 2019 09:06:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anton-vinogradov commented on issue #6701: IGNITE-11961 Provide JMX metrics for PME timings URL: https://github.com/apache/ignite/pull/6701#issuecomment-515372312 > @NSAmelchev > @anton-vinogradov > > I thought we should **add** new metrics to calculate blocking period. > Don't think we should remove existing metrics for a whole PME duration. > > In the end we should have: > > * `CurrentPMEDuration` (existing metric, we shouldn't touch it, will be migrated to new framework in [IGNITE-11922](https://issues.apache.org/jira/browse/IGNITE-11922?jql=labels%20%3D%20IEP-35%20ORDER%20BY%20status%20ASC)). > * `CurrentPMECacheOperationsBlockedDuration` - new long metric. only in the new framework, don't appear in `ClusterMetrics` JMX bean. > * `PMEDuration` - new histogram. > * `PMECacheOperationsBlockedDuration` - new histogram. > > WDYT? Mostly agree, but this should be performed at another issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services