From notifications-return-4625-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jul 26 08:47:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 17C48180595 for ; Fri, 26 Jul 2019 10:47:26 +0200 (CEST) Received: (qmail 64859 invoked by uid 500); 26 Jul 2019 08:47:26 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 64850 invoked by uid 99); 26 Jul 2019 08:47:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2019 08:47:26 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings Message-ID: <156413084139.8518.2706574330774427196.gitbox@gitbox.apache.org> Date: Fri, 26 Jul 2019 08:47:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings URL: https://github.com/apache/ignite/pull/6701#discussion_r307646457 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/GridMetricManager.java ########## @@ -135,6 +136,12 @@ /** Daemon thread count metric name. */ public static final String DAEMON_THREAD_CNT = "DaemonThreadCount"; + /** Cache operations blocked duration metric name. */ + public static final String CACHE_OPERATIONS_BLOCKED_DURATION = "cacheOperationsBlockedDuration"; Review comment: The naming of the metrics differs. Why? Let's make it consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services