From notifications-return-4308-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Jul 22 09:42:42 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CC35118064F for ; Mon, 22 Jul 2019 11:42:41 +0200 (CEST) Received: (qmail 46823 invoked by uid 500); 22 Jul 2019 09:42:41 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 46813 invoked by uid 99); 22 Jul 2019 09:42:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2019 09:42:41 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] Mmuzaf commented on a change in pull request #6688: IGNITE-3195 Rebalancing: IgniteConfiguration.rebalanceThreadPoolSize is wrongly treated Message-ID: <156378856117.23675.11559436415035637587.gitbox@gitbox.apache.org> Date: Mon, 22 Jul 2019 09:42:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Mmuzaf commented on a change in pull request #6688: IGNITE-3195 Rebalancing: IgniteConfiguration.rebalanceThreadPoolSize is wrongly treated URL: https://github.com/apache/ignite/pull/6688#discussion_r305757614 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemandMessage.java ########## @@ -179,7 +179,9 @@ Object topic() { /** * @param topic Topic. + * @deprecated Useless. Review comment: I think we should describe here, why it is not used anymore. Since it's only internal API, should we just remove it without deprecation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services