From notifications-return-4266-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Jul 16 11:40:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3220518064E for ; Tue, 16 Jul 2019 13:40:32 +0200 (CEST) Received: (qmail 87722 invoked by uid 500); 16 Jul 2019 11:40:31 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 87713 invoked by uid 99); 16 Jul 2019 11:40:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2019 11:40:31 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] anton-vinogradov commented on a change in pull request #6689: IGNITE-11978 javadoc enhancement for the ReadRepair feature Message-ID: <156327722653.23237.8152616921234154264.gitbox@gitbox.apache.org> Date: Tue, 16 Jul 2019 11:40:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anton-vinogradov commented on a change in pull request #6689: IGNITE-11978 javadoc enhancement for the ReadRepair feature URL: https://github.com/apache/ignite/pull/6689#discussion_r303861694 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GatewayProtectedCacheProxy.java ########## @@ -236,22 +236,26 @@ public void setCacheManager(org.apache.ignite.cache.CacheManager cacheMgr) { CacheOperationGate opGate = onEnter(); try { - if (context().mvccEnabled()) // Can (should?) be supported in future. - throw new UnsupportedOperationException("Read Repair is not supported at MVCC mode."); + if (context().mvccEnabled()) { + throw new UnsupportedOperationException( + "The TRANSACTIONAL_SNAPSHOT mode does not support the read-repair feature."); + } - if (context().isNear()) // Can be supported in future. - throw new UnsupportedOperationException("Read Repair is not supported for near caches."); + if (context().isNear()) + throw new UnsupportedOperationException("Read-repair is not supported by near caches."); - if (context().readThrough()) // Can be supported in future. + if (context().readThrough()) { // Read Repair get operation produces different versions for same entries loaded via readThrough feature. - throw new UnsupportedOperationException("Read Repair is not supported for caches with readThrough enabled."); + throw new UnsupportedOperationException("Read-repair is not supported by caches with readThrough enabled."); Review comment: You're unable to create withRR proxy because RR feature does not support such cache configuration. So, you may say "not supported by RR" or "this configuration incompatible with RR feature" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services