From notifications-return-4036-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Jul 3 09:19:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B6FEF180109 for ; Wed, 3 Jul 2019 11:19:13 +0200 (CEST) Received: (qmail 79723 invoked by uid 500); 3 Jul 2019 09:19:13 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 79714 invoked by uid 99); 3 Jul 2019 09:19:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jul 2019 09:19:13 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] denis-chudov commented on a change in pull request #6661: IGNITE-11954 Message-ID: <156214554953.25183.10049489932192155233.gitbox@gitbox.apache.org> Date: Wed, 03 Jul 2019 09:19:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit denis-chudov commented on a change in pull request #6661: IGNITE-11954 URL: https://github.com/apache/ignite/pull/6661#discussion_r299853931 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java ########## @@ -182,30 +277,40 @@ public int execute(List rawArgs) { } } + logger.info("Command [" + commandName + "] finished with code: " + EXIT_CODE_OK); return EXIT_CODE_OK; } catch (IllegalArgumentException e) { - logger.error("Check arguments.", e); + logger.severe("Check arguments. " + CommandLogger.errorMessage(e)); + logger.info("Command [" + commandName + "] finished with code: " + EXIT_CODE_INVALID_ARGUMENTS); Review comment: I think you should either add empty line or replace 'info' with 'severe' here and 3 places below in this method ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services