From notifications-return-4187-apmail-ignite-notifications-archive=ignite.apache.org@ignite.apache.org Wed Jul 10 12:32:11 2019 Return-Path: X-Original-To: apmail-ignite-notifications-archive@minotaur.apache.org Delivered-To: apmail-ignite-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id ACAB019693 for ; Wed, 10 Jul 2019 12:32:11 +0000 (UTC) Received: (qmail 59204 invoked by uid 500); 10 Jul 2019 12:32:11 -0000 Delivered-To: apmail-ignite-notifications-archive@ignite.apache.org Received: (qmail 59192 invoked by uid 500); 10 Jul 2019 12:32:11 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 59182 invoked by uid 99); 10 Jul 2019 12:32:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jul 2019 12:32:11 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] sk0x50 commented on a change in pull request #5656: IGNITE-10663 Read Repair Message-ID: <156276193116.29097.7193759530736540568.gitbox@gitbox.apache.org> Date: Wed, 10 Jul 2019 12:32:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sk0x50 commented on a change in pull request #5656: IGNITE-10663 Read Repair URL: https://github.com/apache/ignite/pull/5656#discussion_r302021407 ########## File path: modules/core/src/main/java/org/apache/ignite/events/CacheConsistencyViolationEvent.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.events; + +import java.util.Map; +import java.util.UUID; +import org.apache.ignite.cluster.ClusterNode; + +import static org.apache.ignite.events.EventType.EVT_CONSISTENCY_VIOLATION; + +/** + * Event indicates consistency violation detection. + * + * @see EventType#EVT_CONSISTENCY_VIOLATION + */ +public class CacheConsistencyViolationEvent extends EventAdapter { + /** Serial version UID. */ + private static final long serialVersionUID = 0L; + + /** Original distribution. */ + Map> locEntries; + + /** Fixed entries. */ + Map fixedEntries; + + /** + * + */ + public CacheConsistencyViolationEvent( + ClusterNode node, + String msg, + Map> locEntries, + Map fixedEntries) { + super(node, msg, EVT_CONSISTENCY_VIOLATION); + + this.locEntries = locEntries; + this.fixedEntries = fixedEntries; + } + + /** + * Original distribution. Review comment: Please update Javadoc to provide a good description. What does `original distribution` mean? For example, `UUID` - is it primary node id? **The Javadoc is the face of the product and it must be good enough for all users, especially if we are talking about public API.** Also, there is no test that covers this method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services