ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] NSAmelchev commented on a change in pull request #6701: IGNITE-11961 Provide JMX metrics for PME timings
Date Tue, 30 Jul 2019 12:07:24 GMT
NSAmelchev commented on a change in pull request #6701: IGNITE-11961  Provide JMX metrics for
PME timings
URL: https://github.com/apache/ignite/pull/6701#discussion_r308682965
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/GridMetricManager.java
 ##########
 @@ -198,10 +214,20 @@ public GridMetricManager(GridKernalContext ctx) {
         sysreg.register(DAEMON_THREAD_CNT, threads::getDaemonThreadCount, null);
         sysreg.register("CurrentThreadCpuTime", threads::getCurrentThreadCpuTime, null);
         sysreg.register("CurrentThreadUserTime", threads::getCurrentThreadUserTime, null);
+
+        MetricRegistry pmeReg = registry(PME_METRICS);
+
+        long[] pmeBounds = new long[] {500, 1000, 5000, 30000};
+
+        pmeReg.histogram(PME_DURATION, pmeBounds,
+            "Histogram of PME durations in milliseconds.");
+
+        pmeReg.histogram(PME_CACHE_OPERATIONS_BLOCKED_DURATION, pmeBounds,
+            "Histogram of cache operations blocked PME durations in milliseconds.");
     }
 
     /** {@inheritDoc} */
-    @Override protected void onKernalStart0() throws IgniteCheckedException {
+    @Override protected void onKernalStart0() {
 
 Review comment:
   Reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message