ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] sk0x50 commented on a change in pull request #6689: IGNITE-11978 javadoc enhancement for the ReadRepair feature
Date Tue, 16 Jul 2019 19:09:51 GMT
sk0x50 commented on a change in pull request #6689: IGNITE-11978 javadoc enhancement for the
ReadRepair feature
URL: https://github.com/apache/ignite/pull/6689#discussion_r303924064
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GatewayProtectedCacheProxy.java
 ##########
 @@ -236,22 +236,26 @@ public void setCacheManager(org.apache.ignite.cache.CacheManager cacheMgr)
{
         CacheOperationGate opGate = onEnter();
 
         try {
-            if (context().mvccEnabled()) // Can (should?) be supported in future.
-                throw new UnsupportedOperationException("Read Repair is not supported at
MVCC mode.");
+            if (context().mvccEnabled()) {
+                throw new UnsupportedOperationException(
+                    "The TRANSACTIONAL_SNAPSHOT mode does not support the read-repair feature.");
+            }
 
-            if (context().isNear()) // Can be supported in future.
-                throw new UnsupportedOperationException("Read Repair is not supported for
near caches.");
+            if (context().isNear())
+                throw new UnsupportedOperationException("Read-repair is not supported by
near caches.");
 
-            if (context().readThrough()) // Can be supported in future.
+            if (context().readThrough()) {
                 // Read Repair get operation produces different versions for same entries
loaded via readThrough feature.
-                throw new UnsupportedOperationException("Read Repair is not supported for
caches with readThrough enabled.");
+                throw new UnsupportedOperationException("Read-repair is not supported by
caches with readThrough enabled.");
 
 Review comment:
   > Cache unable to support something.
   
   Of course, a cache is able to support something! :) hmm, perhaps, the phrase `Operation
(RR) incompatible with...` is good enough.
   
   > RR cannot be performed on local cache because it's local :)
   
   I try to talk about the definition itself and not about the particular case (local cache/near
cache)
   It seems we need some sort of arbiter :) Maybe, @nizhikov Nikolay Izhikov will step in
with his vision about this important discussion )))
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message