ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] sk0x50 commented on a change in pull request #6689: IGNITE-11978 javadoc enhancement for the ReadRepair feature
Date Tue, 16 Jul 2019 10:50:33 GMT
sk0x50 commented on a change in pull request #6689: IGNITE-11978 javadoc enhancement for the
ReadRepair feature
URL: https://github.com/apache/ignite/pull/6689#discussion_r303843956
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/IgniteCache.java
 ##########
 @@ -145,8 +147,10 @@
      *  <li>for transactional caches:
      *  <p>values across the topology will be replaced by latest versioned value:
      *  <ul>
-     *      <li>automaticaly for OPTIMISTIC || READ_COMMITTED transactions</li>
-     *      <li>at commit() for PESSIMISTIC && !READ_COMMITTED transactions</li>
+     *      <li>automatically for transactions that have {@link TransactionConcurrency#OPTIMISTIC}
concurrency mode
+     *          or {@link TransactionIsolation#READ_COMMITTED} isolation level</li>
+     *      <li>at commit() phase for transactions that have {@link TransactionConcurrency#PESSIMISTIC}
concurrency mode
+     *          and isolation level other than {@link TransactionIsolation#READ_COMMITTED}</li>
 
 Review comment:
   I am definitely not an expert, but I think it is absolutely correct.
   It is widely used in the Java API, for instance:
   ```java
   An IllegalAccessException is thrown when an application tries to reflectively create an
instance (other than an array),
   set or get a field, or invoke a method, but the currently executing method does not have
access to the definition of the specified class, field, method or constructor.
   ```
   
   Also, the definition of 'other than' can be found at Cambridge Dictionary, Merriam-Webster
and etc.
   https://dictionary.cambridge.org/dictionary/english/other-than
   https://www.merriam-webster.com/dictionary/other%20than

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message