ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] denis-chudov commented on a change in pull request #6661: IGNITE-11954
Date Wed, 03 Jul 2019 09:19:09 GMT
denis-chudov commented on a change in pull request #6661: IGNITE-11954
URL: https://github.com/apache/ignite/pull/6661#discussion_r299853931
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java
 ##########
 @@ -182,30 +277,40 @@ public int execute(List<String> rawArgs) {
                 }
             }
 
+            logger.info("Command [" + commandName + "] finished with code: " + EXIT_CODE_OK);
             return EXIT_CODE_OK;
         }
         catch (IllegalArgumentException e) {
-            logger.error("Check arguments.", e);
+            logger.severe("Check arguments. " + CommandLogger.errorMessage(e));
+            logger.info("Command [" + commandName + "] finished with code: " + EXIT_CODE_INVALID_ARGUMENTS);
 
 Review comment:
   I think you should either add empty line or replace 'info' with 'severe' here and 3 places
below in this method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message