ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on issue #6648: IGNITE-11922 `Register ClusterMetricsMXBeanImpl metrics`
Date Tue, 02 Jul 2019 12:22:53 GMT
nizhikov commented on issue #6648: IGNITE-11922 `Register ClusterMetricsMXBeanImpl metrics`
URL: https://github.com/apache/ignite/pull/6648#issuecomment-507653155
 
 
   1. Please, solve merge conflicts
   2. We should cache specific Counters instead of query it from registry on each access.
   3. Please, double check usages of `add` and `set`. `add` - ads some value to the counter
while `set` sets it. Seems, we have issues with it in the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message