From notifications-return-3978-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Jun 27 09:25:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BC8E818072F for ; Thu, 27 Jun 2019 11:25:04 +0200 (CEST) Received: (qmail 99084 invoked by uid 500); 27 Jun 2019 09:25:04 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 99062 invoked by uid 99); 27 Jun 2019 09:25:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jun 2019 09:25:04 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ibessonov commented on a change in pull request #6564: IGNITE-11869 Rework command handler tests Message-ID: <156162750402.24933.7367735750705780714.gitbox@gitbox.apache.org> Date: Thu, 27 Jun 2019 09:25:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ibessonov commented on a change in pull request #6564: IGNITE-11869 Rework command handler tests URL: https://github.com/apache/ignite/pull/6564#discussion_r298082189 ########## File path: modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java ########## @@ -298,6 +300,86 @@ public static void dumpMessages() { // }).start(); // } + /** + * Checks that string {@param str} doesn't contains substring {@param substr}. Logs both strings + * and throws {@link java.lang.AssertionError}, if contains. + * + * @param log Logger (optional). + * @param str String. + * @param substr Substring. + */ + public static void assertNotContains(@Nullable IgniteLogger log, String str, String substr) { + try { + assertFalse(str.contains(substr)); + } catch (AssertionError e) { Review comment: Please reformat this code (and other methods as well) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services