From notifications-return-3910-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jun 21 13:57:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E91631807CA for ; Fri, 21 Jun 2019 15:57:30 +0200 (CEST) Received: (qmail 55998 invoked by uid 500); 21 Jun 2019 13:57:29 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 55637 invoked by uid 99); 21 Jun 2019 13:57:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jun 2019 13:57:28 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ibessonov commented on a change in pull request #6536: IGNITE-6957 Boxing / Unboxing optimization - added IntSet. Message-ID: <156112544680.19884.3258501038019606354.gitbox@gitbox.apache.org> Date: Fri, 21 Jun 2019 13:57:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ibessonov commented on a change in pull request #6536: IGNITE-6957 Boxing / Unboxing optimization - added IntSet. URL: https://github.com/apache/ignite/pull/6536#discussion_r295897045 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/affinity/GridAffinityAssignmentV2.java ########## @@ -333,23 +333,25 @@ public GridAffinityAssignmentV2(AffinityTopologyVersion topVer, /** {@inheritDoc} */ @Override protected void writeExternalData(ObjectOutput out) throws IOException { - out.writeObject(topVer); + throw new RuntimeException("TODO"); + /* out.writeObject(topVer); U.writeCollection(out, assignment); - U.writeMap(out, primary); + U.writeMap(out, primary); //todo - U.writeMap(out, backup); + U.writeMap(out, backup); //todo*/ } /** {@inheritDoc} */ @Override protected void readExternalData(byte protoVer, ObjectInput in) throws IOException, ClassNotFoundException { - topVer = (AffinityTopologyVersion)in.readObject(); + throw new RuntimeException("TODO"); Review comment: Same here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services