From notifications-return-3817-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Jun 13 09:49:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9BD23180780 for ; Thu, 13 Jun 2019 11:49:03 +0200 (CEST) Received: (qmail 73683 invoked by uid 500); 13 Jun 2019 09:49:03 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 73674 invoked by uid 99); 13 Jun 2019 09:49:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2019 09:49:03 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ascherbakoff commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1 Message-ID: <156041934306.1859.14282889834830426989.gitbox@gitbox.apache.org> Date: Thu, 13 Jun 2019 09:49:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ascherbakoff commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1 URL: https://github.com/apache/ignite/pull/6546#discussion_r293295041 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/metric/IoStatisticsHolderCache.java ########## @@ -48,12 +50,23 @@ /** * @param cacheName Name of cache. + * @param grpId Group id. + * @param mreg Metric registry. */ - public IoStatisticsHolderCache(String cacheName, int grpId) { + public IoStatisticsHolderCache(String cacheName, int grpId, MetricRegistry mreg) { assert cacheName != null; this.cacheName = cacheName; this.grpId = grpId; + + MetricRegistry mset = mreg.withPrefix(CACHE_GROUP.metricGroupName(), cacheName); Review comment: mset doesn't look very descriptive, see RULE2 of abbreviation rules. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services