From notifications-return-3758-archive-asf-public=cust-asf.ponee.io@ignite.apache.org  Mon Jun 10 09:51:28 2019
Return-Path: <notifications-return-3758-archive-asf-public=cust-asf.ponee.io@ignite.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 0513D180649
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 10 Jun 2019 11:51:27 +0200 (CEST)
Received: (qmail 96755 invoked by uid 500); 10 Jun 2019 09:51:27 -0000
Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@ignite.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@ignite.apache.org>
List-Post: <mailto:notifications@ignite.apache.org>
List-Id: <notifications.ignite.apache.org>
Reply-To: dev@ignite.apache.org
Delivered-To: mailing list notifications@ignite.apache.org
Received: (qmail 96745 invoked by uid 99); 10 Jun 2019 09:51:27 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2019 09:51:27 +0000
From: GitBox <git@apache.org>
To: notifications@ignite.apache.org
Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #5744:
 IGNITE-10803:[ML] Add prototype LogReg loading from PMML format
Message-ID: <156016028727.28109.14466859623765976521.gitbox@gitbox.apache.org>
Date: Mon, 10 Jun 2019 09:51:27 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

nizhikov commented on a change in pull request #5744: IGNITE-10803:[ML] Add prototype LogReg loading from PMML format
URL: https://github.com/apache/ignite/pull/5744#discussion_r291948305
 
 

 ##########
 File path: examples/pom.xml
 ##########
 @@ -122,6 +122,30 @@
             <version>${javassist.version}</version>
             <scope>test</scope>
         </dependency>
+        <!-- https://mvnrepository.com/artifact/org.jpmml/pmml-evaluator -->
+        <dependency>
+            <groupId>org.jpmml</groupId>
+            <artifactId>pmml-evaluator</artifactId>
 
 Review comment:
   Hello, @zaleslaw.
   
   Thanks for the response!
   
   Yes, I fixed that, already.
   
   You can see my commit, if interested - 678e445
   
   Also, It's not only your fault :)
   There was some misconfiguration on TC, so tests you broke with this change weren't tested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services