From notifications-return-3752-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Jun 10 09:04:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B530A18067E for ; Mon, 10 Jun 2019 11:04:35 +0200 (CEST) Received: (qmail 3551 invoked by uid 500); 10 Jun 2019 09:04:35 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 3542 invoked by uid 99); 10 Jun 2019 09:04:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2019 09:04:35 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6483: IGNITE-5714 Implementation of suspend/resume for pessimistic transactions Message-ID: <156015746992.12475.18298356760758695842.gitbox@gitbox.apache.org> Date: Mon, 10 Jun 2019 09:04:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alex-plekhanov commented on a change in pull request #6483: IGNITE-5714 Implementation of suspend/resume for pessimistic transactions URL: https://github.com/apache/ignite/pull/6483#discussion_r291933570 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMvcc.java ########## @@ -1331,12 +1331,31 @@ public void remove(GridCacheVersion ver) { @Nullable public GridCacheMvccCandidate localCandidate(UUID nodeId, long threadId) { if (locs != null) for (GridCacheMvccCandidate c : locs) - if (c.nodeId().equals(nodeId) && c.threadId() == threadId) + if (c.nodeId().equals(nodeId) && c.isHeldByThread(threadId)) return c; return null; } + /** + * Near local candidate. + * + * @param nodeId Node ID. + * @param threadId Thread ID. + * @param ver Lock version. Review comment: Such a description is commonly used all over the class for this parameter, I don't see a reason to make an exception here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services